Extract temporary and permanent storage changes #123
+932
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpani
force-pushed
the
th/storage-perm-temp
branch
from
76e678f
to
dcddf35
Compare
konnov
approved these changes
Sep 23, 2024
Oh, I didn't notice I requested a review already 😅 |
thpani
force-pushed
the
th/storage-perm-temp
branch
from
e0d6051
to
3a04627
Compare
|
@konnov I've added persistent/temporary fields in the setter contract and to the tests. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory change towards #54.
Closes #121
Closes #126
In the fetcher, extract all ledger entry changes from a transaction, i.e, including
The result is two (pre- & post-state) nested maps keyed by
ScValkey, SDK-transformed to a native JS val and.toString()edThe resulting maps are only propagated to Solarkraft on-disk storage, and not yet used for instrumentation. In particular, we still populate
fieldsandoldFieldsby projecting the above maps to the instance storage of the root-invocation contract ID.Tests:
Update the setter contract to store all fields in instance, persistent and temporary storage.
Note that the presence of fields is different between instance and persistent/temporary:
instance is a single
LedgerEntry, thus all instance fields are present if a single instance field changes.persistent/temporary have one
LedgerEntryper field, thus they are only present in the transaction if that field is changed.We should follow up with case studies to determine user needs: